-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-19] Add markdown support to Todos #20
Conversation
In order to add markdown, I have taken a few utils files from webapp, and stripped them down from many things that were not needed for this, and were using other webapp components. Due to this stripping, some potential bugs may have been created, but should not be the case. |
Made changes to use webapp exported PostUtils instead of creating our own markdown parser in my latest commit. Now it is simpler, cleaner, and should work better (since it is using webapp version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @larkox for researching and fixing this!
The "Add Todo" modal is now behind in that it can use a markdown-aware edit box, I'll file it as a separate issue. We can use it in other plugins as well (Jira, GitHub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
@DHaussermann I already tested this change minimally (built the plugin and tried some markdown) and it appears to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Add markdown support to Todos
Ticket Link
Fixes #19